CodeSOD: Off Color

Carolyn inherited a somewhat old project that had been initiated by a “rockstar” developer, and then passed to developer after developer over the years. They burned through rockstars faster than Spinal Tap goes through drummers. The result is gems like this:

private <span class="hljs-keyword">void</span> <span class="hljs-title function_">init</span>(<span class="hljs-params"></span>){
	<span class="hljs-title class_">ResourceHelper</span> rh = <span class="hljs-keyword">new</span> <span class="hljs-title class_">ResourceHelper</span>();
	<span class="hljs-keyword">for</span> ( int i = <span class="hljs-number">0</span>; i < <span class="hljs-number">12</span>; i++) {
		months[i] = rh.<span class="hljs-title function_">getResource</span>(<span class="hljs-string">"calendar."</span>+monthkeys[i]+<span class="hljs-string">".long"</span>);
		months_s[i] = rh.<span class="hljs-title function_">getResource</span>(<span class="hljs-string">"calendar."</span>+monthkeys[i]+<span class="hljs-string">".short"</span>);
	}
	<span class="hljs-title class_">StaticData</span> data = <span class="hljs-title class_">SomeService</span>.<span class="hljs-title function_">current</span>().<span class="hljs-title function_">getStaticData</span>();
	<span class="hljs-variable language_">this</span>.<span class="hljs-property">bankHolidayList</span> = data.<span class="hljs-title function_">getBankHolidayList</span>();
	colors.<span class="hljs-title function_">put</span>(<span class="hljs-string">"#dddddd"</span>, <span class="hljs-string">"#dddddd"</span>);
	colors.<span class="hljs-title function_">put</span>(<span class="hljs-string">"#cccccc"</span>, <span class="hljs-string">"#cccccc"</span>);
	colors.<span class="hljs-title function_">put</span>(<span class="hljs-string">"#e6e6e6"</span>, <span class="hljs-string">"#e6e6e6"</span>);
	colors.<span class="hljs-title function_">put</span>(<span class="hljs-string">"#ff0000"</span>, <span class="hljs-string">"#ffcccc"</span>);
	colors.<span class="hljs-title function_">put</span>(<span class="hljs-string">"#ffff00"</span>, <span class="hljs-string">"#ffffcc"</span>);
	colors.<span class="hljs-title function_">put</span>(<span class="hljs-string">"#00ff00"</span>, <span class="hljs-string">"#ccffcc"</span>);
	colors.<span class="hljs-title function_">put</span>(<span class="hljs-string">"#5050ff"</span>, <span class="hljs-string">"#ccccff"</span>);
	colors.<span class="hljs-title function_">put</span>(<span class="hljs-string">"#aa0000"</span>, <span class="hljs-string">"#ff9999"</span>);
	colors.<span class="hljs-title function_">put</span>(<span class="hljs-string">"#ff8000"</span>, <span class="hljs-string">"#ffcc99"</span>);
	colors.<span class="hljs-title function_">put</span>(<span class="hljs-string">"#99ff99"</span>, <span class="hljs-string">"#ccffcc"</span>);
	colors.<span class="hljs-title function_">put</span>(<span class="hljs-string">"#ffcc99"</span>, <span class="hljs-string">"#ffffcc"</span>);
	colors.<span class="hljs-title function_">put</span>(<span class="hljs-string">"#ff9966"</span>, <span class="hljs-string">"#ffcc99"</span>);
	colors.<span class="hljs-title function_">put</span>(<span class="hljs-string">"#00c040"</span>, <span class="hljs-string">"#99cc99"</span>);
	colors.<span class="hljs-title function_">put</span>(<span class="hljs-string">"#aadddd"</span>, <span class="hljs-string">"#ccffff"</span>);
	colors.<span class="hljs-title function_">put</span>(<span class="hljs-string">"#e0e040"</span>, <span class="hljs-string">"#ffff99"</span>);
	colors.<span class="hljs-title function_">put</span>(<span class="hljs-string">"#6699ff"</span>, <span class="hljs-string">"#99ccff"</span>);
}

There are plenty of things in this function that raise concerns- whatever is going on with the ResourceHelper and the monthkeys array, for example. But let’s just breeze past that into that colors lookup table, because boy oh boy.

There’s the obvious issue of using server-side code to manage colors instead of CSS, which is bad, sure. But this translation table which converts some colors (presumably already used in the display?) to some other colors (presumably to replace the display colors) is downright mystifying. How did this happen? Why did this happen? What happens when we attempt to apply a color not in the lookup table?

I want to say more mean things about this, but the more I stare at the original colors and what they get translated to, I think this lookup table is trying to tell me I should…

…
…

lighten up.

[Advertisement]
Keep the plebs out of prod. Restrict NuGet feed privileges with ProGet. Learn more.

Source: Read More