Sebastian is now maintaining a huge framework which, in his words, “could easily be reduced in size by 50%”, especially because many of the methods in it are reinvented wheels that are already provided by .NET and specifically LINQ.
For example, if you want the first item in a collection, LINQ lets you call First() or FirstOrDefault() on any collection. The latter option makes handling empty collections easier. But someone decided to reinvent that wheel, and like so many reinvented wheels, it’s worse.
<span class="hljs-function"><span class="hljs-keyword">public</span> <span class="hljs-keyword">static</span> LoggingRule <span class="hljs-title">FindFirst</span> (<span class="hljs-params"><span class="hljs-keyword">this</span> IEnumerable<LoggingRule> rules, Func<LoggingRule, <span class="hljs-built_in">bool</span>> predicate</span>)</span>
{
<span class="hljs-keyword">foreach</span> (LoggingRule rule <span class="hljs-keyword">in</span> rules) {
<span class="hljs-keyword">return</span> rule;
}
<span class="hljs-keyword">return</span> <span class="hljs-literal">null</span>;
}
This function takes a list of logging rules and a function to filter the logging rules, starts a for loop to iterate over the list, and then simply returns the first element in the list, thus exiting the for loop. If the loop doesn’t contain any elements, we return null.
From the signature, I’d expect this function to do filtering, but it clearly doesn’t. It just returns the first element, period. And again, there’s already a built-in function for that. I don’t know why this is exists, but I especially dislike that it’s so misleading.
There’s only one positive to say about this: if you did want to reduce the size of the framework by 50%, it’s easy to see where I’d start.
[Advertisement]BuildMaster allows you to create a self-service release management platform that allows different teams to manage their applications. Explore how!
Source: Read MoreÂ
