Maybe we’ll just try and read a book. That’s a good way to spend your vacation. This can’t possibly go badly! Original —Remy
.JPG)
“Have you had a chance to look at that JIRA ticket yet?”
Marge debated pretending she hadn’t seen the Slack message yet—but, if she did, she knew Gary would just walk over to her desk and badger her further. In truth, she didn’t want to look at the ticket: it was a low priority ticket, and worse, it only affected a small fraction of one client’s customers, meaning it was likely to be some weird edge case bug nobody would ever run into again. Maybe if I ignore it long enough, it’ll go away on its own, she thought.
The client was a bookseller with a small but signifigant-to-them online presence; the software they used to sell books, including your standard e-commerce account functionality, was made by Marge’s company. The bug was somewhere in the password reset feature: some customers, seemingly at random, were unable to use the password reset link the software emailed out.
Marge pulled up the ticket, looking over the half-hearted triage work that had been done before it landed on her desk to solve. The previous guy had pulled logs and figured out that all the customers who were complaining were using the same ISP based out of Germany. He’d recommended reaching out to them, but had been transferred to another division before he’d gotten around to it.
When Marge realized that the contact information was all in German, she almost gave up then and there. But with the magic of Google Translate, she managed to get in touch with a representative via email. After a bit of back and forth, she noticed this gem in one of his (translated) replies:
We want to display mails in our webmail client as close to the original as possible. Since most mails are HTML formatted, the client supports the full HTTP protocol and can display (almost) all HTML tags. Unfortunately, this means that “evil” JS-Content in such mails can do all kinds of stuff in the browser and therefore on the customer’s PC.
To avert this, all mails are processed by a “SafeBrowsing”-module before they are displayed, to recognize and circumvent such manipulations.
One of those security measures is the recognition of js-modules that begin with “on…”, since that are mostly js functions that are triggered by some event in the browser. Our “countermeasure” is to just replace “on…” with “no…” before the HTML content is sent to the rendering process.
Marge frowned at the answer for a bit, something nagging at her mind. “There’s no way,” she murmured as she pulled up the access logs. Sure enough, the url for the reset link was something like https://bookseller.com?oneTimeToken=deadbeef … and the customers in question had accessed https://bookseller.com?noeTimeToken=deadbeef instead.
A few lines of code and it was resolved: a conditional would check for the incorrect query string parameter and copy the token to the correct query string parameter instead. Marge rolled her eyes, merged her change into the release branch, and finally, at long last, closed that annoying low-priority ticket once and for all.
[Advertisement]Source: Read MoreÂ
